feat: add producer connectivity functionality #286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested changes
Jan 27, 2026
Contributor
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
is_connected is a wrong legacy design that should not have been added. Actually, it returns false during the reconnection. For example,
- t0: The ownership changed, broker sent a notification to client to disconnect
- t0 + 100 ms: Schedule a new reconnection
- t1: The reconnection was done
is_connected() returns false between [t0, t0 + 100 ms). However, this result is meaningless to users. Users should not do anything for it.
Contributor
Author
Is there a similar option we would want to add around this functionality? Happy to pickup any other async.io tasks to get as much support added ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Expanding async producer support. Some functions are simply missing mappings to the async sibling.
Modifications
Adds producer connectivity functionality to the async producer.
Issue
#278